Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Fix error handling for job handler in route #60161

Merged
merged 4 commits into from
Mar 16, 2020

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Mar 13, 2020

Summary

Fix #60154

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@tsullivan tsullivan added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:fix v7.6.2 v7.7.0 v8.0.0 labels Mar 13, 2020
@tsullivan tsullivan changed the title fix bogus rison error [Reporting] Fix error handling for job handler in route Mar 16, 2020
} as unknown) as Logger;

beforeEach(async () => {
mockServer = new Hapi.Server({
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have to be changed when we migrate server routes

Copy link
Contributor

@joelgriffith joelgriffith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. After getting onto new-platform we should probably break out the query-param route and the POST body route into their own special handlers? There's a lot of weird logic forks due to handling both.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit 537fa8c into elastic:master Mar 16, 2020
@tsullivan tsullivan deleted the reporting/fix-flaky-rison-err branch March 16, 2020 21:26
tsullivan added a commit to tsullivan/kibana that referenced this pull request Mar 16, 2020
* fix bogus rison error

* add generate route test

* update test name
tsullivan added a commit to tsullivan/kibana that referenced this pull request Mar 16, 2020
* fix bogus rison error

* add generate route test

* update test name
tsullivan added a commit that referenced this pull request Mar 17, 2020
)

* fix bogus rison error

* add generate route test

* update test name
@tsullivan tsullivan removed the v7.6.2 label Mar 17, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 17, 2020
* master: (30 commits)
  [TSVB] fix text color when using custom background color (elastic#60261)
  Fix import to timefilter from in TSVB (elastic#60296)
  [NP] Get rid of usage redirectWhenMissing service (elastic#59777)
  [SIEM] Fix Timeline footer styling (elastic#59587)
  [ML] Fixes to error handling for analytics jobs and file data viz (elastic#60249)
  Give better stack traces for Unhandled Promise Rejection warnings (elastic#60235)
  resolves elastic#58905 (elastic#60120)
  Added variables button for text fields in Pagerduty component. (elastic#60189)
  adds test that action vars are rendered for alert action parms (elastic#60310)
  Closes 59786 by removing the update toast (elastic#60172)
  [EPM] Packages list tabs (elastic#60167)
  Added message variables button for Webhook body form field (elastic#60174)
  Revert "adds new test (elastic#60064)"
  [Maps] move MapSavedObject type out of telemetry (elastic#60127)
  [Reporting] Fix error handling for job handler in route (elastic#60161)
  [Endpoint] TEST: verify alerts page header says 'Alerts' (elastic#60206)
  EMT-248: implement ack resource to accept event payload to acknowledge agent actions (elastic#60218)
  Migrate dual validated range (elastic#59689)
  Embeddable triggers (elastic#58440)
  [Endpoint] Sample data generator CLI script (elastic#59952)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:fix v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reporting] Queuing reporting jobs fails due to "invalid rison"
3 participants